Skip to content

Conversation

@ncsokas
Copy link
Contributor

@ncsokas ncsokas commented Oct 24, 2025

This pull request adds a step-by-step guide to the labs/concurrency.md file, explaining how to implement and test a concurrency-controlled GitHub Actions workflow. The documentation includes example YAML snippets and detailed instructions for setting up jobs, configuring concurrency, and using workflow summaries.

@ncsokas ncsokas requested a review from michaelin October 24, 2025 09:33
Copy link
Contributor

@michaelin michaelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as intended and I like that is much more succinct than the others in general.

  • I'd like an introduction stating at least the learning goals, so that you know the context and intended outcome before starting the exercise tasks.
  • Bullets 1-3 could probably be a single bullet, whereas it could be nice to split bullet 7 a bit. Maybe extract some of the logic around writing tree.txt and waiting into a script to make the instructions simpler.
  • For both step 7 and 8 I think it is a bit confusing that the wait part isn't in the details, while everything else is.

These are suggestions, as the exercise works and is correct as it is.

@ncsokas ncsokas requested a review from michaelin November 3, 2025 12:24
Copy link
Contributor

@michaelin michaelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it 👍

@michaelin michaelin merged commit b6bd15f into main Nov 4, 2025
@michaelin michaelin deleted the new-exercise/concurrency branch November 4, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants